Short-circuit when insert values are empty #229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If
InsertParams.values
is an empty array, no request is sent to the server, andClickHouseClient.insert
short-circuits itself. In this scenario, the newly addedInsertResult.executed
flag will befalse
, andInsertResult.query_id
will be an empty string.Client no longer produces
Code: 354. inflate failed: buffer error
exception if request compression is enabled andInsertParams.values
is an empty array (see above).Checklist
Delete items not relevant to your PR: